-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Requisition Hook Guidance #60
Added Requisition Hook Guidance #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@CanYumusak do you want to add the example LogSnag hook as a file before I merge this? |
Sure, give me a sec |
Done! ☑️ |
My point exactly why this might not work so well in docker. You got it to work for example purposes but for somebody who wants to do something else, they might face similar issues. Of course, you can do your own Docker image based on current one which is what I often end up doing. Not to mention the permission issues related to files, if the script creates any. I actually earlier made a PR to update the README so that there would be options of running ynabber as a regular user in the example, but @martinohansen declined that. This easily becomes even more complicated and I've worked with docker a lot (in fact, daily). Good that the option is there, though. |
Background
When setting up a full requsition hook, I struggled (longer than I would like to admit) to make the hook run in the docker container. The reason for my struggle was missing tools in the docker container such as bash, cuRL and so on. I decided to fix the shebang and write up a guide to make this easier for people after me.
Example Hook for LogSnag